restrict AIX use of clang to 26+ instead of 25+#4307
Merged
sxa merged 2 commits intonodejs:mainfrom Apr 22, 2026
Merged
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
richardlau
reviewed
Apr 22, 2026
| export CXX="clang++" | ||
| echo "Compiler set to Clang" `${CXX} -dumpversion` | ||
| fi | ||
| return |
Member
There was a problem hiding this comment.
You may need the return to be inside the if block for the fall through to work as expected.
Signed-off-by: Stewart X Addison <sxa@ibm.com>
richardlau
approved these changes
Apr 22, 2026
Contributor
|
Thanks for fixing this up @sxa! |
Member
Author
|
https://ci.nodejs.org/job/node-stress-single-test/nodes=aix72-power9/687/console is runnign through ok with 25 so I think this is ok - will also keep an eye on the 26 runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until tested. Building node 25 with clang results in a build failure after #4286 selected clang for 25+ (like the other platforms) instead of 26+
Other option would be to have a separate "if 26 and AIX" section outside the 25+ block but I think this is simpler.